Skip to content

deps: add ngtcp2_fmt.c to build configuration (ngtcp2.gyp)#63821

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShenHongFei:fix-ngtcp2-gyp
Jun 13, 2026
Merged

deps: add ngtcp2_fmt.c to build configuration (ngtcp2.gyp)#63821
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShenHongFei:fix-ngtcp2-gyp

Conversation

@ShenHongFei

@ShenHongFei ShenHongFei commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The following compilation configuration will result in an error.

python configure.py --v8-enable-temporal-support --experimental-quic --experimental-dtls --enable-thin-lto --dest-cpu=x64 --clang-cl=20.1.8

lld-link : warning : ignoring unknown argument '-fno-lto' [D:\1\nodejs\node_mksnapshot.vcxproj]
lld-link : warning : ignoring unknown argument '-flto=thin' [D:\1\nodejs\node_mksnapshot.vcxproj]
lld-link : error : undefined symbol: ngtcp2_fmt_write_str [D:\1\nodejs\node_mksnapshot.vcxproj]
  >>> referenced by ngtcp2\lib\ngtcp2_conn.c
  >>>               ngtcp2.lib(ngtcp2_conn.obj)
  >>> referenced by ngtcp2\lib\ngtcp2_pv.c
  >>>               ngtcp2.lib(ngtcp2_pv.obj)
  >>> referenced by ngtcp2\lib\ngtcp2_log.c
  >>>               ngtcp2.lib(ngtcp2_log.obj)
  >>> referenced 3 more times
  
lld-link : error : undefined symbol: ngtcp2_fmt_write_uint64w [D:\1\nodejs\node_mksnapshot.vcxproj]
  >>> referenced by ngtcp2\lib\ngtcp2_conn.c
  >>>               ngtcp2.lib(ngtcp2_conn.obj)
  >>> referenced by ngtcp2\lib\ngtcp2_pv.c
  >>>               ngtcp2.lib(ngtcp2_pv.obj)
  >>> referenced by ngtcp2\lib\ngtcp2_log.c
  >>>               ngtcp2.lib(ngtcp2_log.obj)
  >>> referenced 3 more times
  
...

After investigation, it was found that the sources section of the ngtcp2.gyp configuration file was missing the ngtcp2_fmt.c file, which caused the linking failure. After adding it, local compilation could be done normally.

@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/quic
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jun 9, 2026
@ShenHongFei

ShenHongFei commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

#63777

This PR has added this file.

image

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74004/

This was referenced Jun 12, 2026
Merged
Closed
Merged
@pimterry pimterry added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2026
@nodejs-github-bot nodejs-github-bot merged commit 96cff60 into nodejs:main Jun 13, 2026
70 of 72 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Landed in 96cff60

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@ShenHongFei @aduh95
deps: add ngtcp2_fmt.c to build configuration (ngtcp2.gyp)
b1b597c 
PR-URL: #63821
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@pimterry pimterry pimterry approved these changes

+2 more reviewers

@efekrskl efekrskl efekrskl approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ShenHongFei @nodejs-github-bot @Qard @jasnell @pimterry @efekrskl @bjohansebas